mirror of
https://github.com/xtr-dev/payload-automation.git
synced 2025-12-10 00:43:23 +00:00
Remove obsolete test files and their associated cases
- Delete unused test files: `basic.test.ts`, `condition-fix.spec.ts`, `create-document-step.test.ts`, and `error-scenarios.spec.ts` - Streamline codebase by eliminating redundant and outdated test cases - Improve maintainability by keeping only relevant and up-to-date tests
This commit is contained in:
@@ -1,113 +0,0 @@
|
||||
import { describe, it, expect, beforeEach, afterEach } from 'vitest'
|
||||
import { getTestPayload, cleanDatabase } from './test-setup.js'
|
||||
|
||||
describe('Workflow Condition Fix Test', () => {
|
||||
|
||||
beforeEach(async () => {
|
||||
await cleanDatabase()
|
||||
})
|
||||
|
||||
afterEach(async () => {
|
||||
await cleanDatabase()
|
||||
})
|
||||
|
||||
it('should correctly evaluate trigger conditions with $.trigger.doc path', async () => {
|
||||
const payload = getTestPayload()
|
||||
|
||||
// Create a workflow with a condition using the correct JSONPath
|
||||
const workflow = await payload.create({
|
||||
collection: 'workflows',
|
||||
data: {
|
||||
name: 'Test Condition Evaluation',
|
||||
description: 'Tests that $.trigger.doc.content conditions work',
|
||||
triggers: [
|
||||
{
|
||||
type: 'collection-trigger',
|
||||
collectionSlug: 'posts',
|
||||
operation: 'create',
|
||||
condition: '$.trigger.doc.content == "TRIGGER_ME"'
|
||||
}
|
||||
],
|
||||
steps: [
|
||||
{
|
||||
name: 'audit-step',
|
||||
step: 'create-document',
|
||||
collectionSlug: 'auditLog',
|
||||
data: {
|
||||
post: '$.trigger.doc.id',
|
||||
message: 'Condition was met and workflow triggered'
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
})
|
||||
|
||||
console.log('Created workflow with condition: $.trigger.doc.content == "TRIGGER_ME"')
|
||||
|
||||
// Create a post that SHOULD NOT trigger
|
||||
const post1 = await payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: 'This should not trigger'
|
||||
}
|
||||
})
|
||||
|
||||
// Create a post that SHOULD trigger
|
||||
const post2 = await payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: 'TRIGGER_ME'
|
||||
}
|
||||
})
|
||||
|
||||
// Wait for workflow execution
|
||||
await new Promise(resolve => setTimeout(resolve, 5000))
|
||||
|
||||
// Check workflow runs - should have exactly 1
|
||||
const runs = await payload.find({
|
||||
collection: 'workflow-runs',
|
||||
where: {
|
||||
workflow: {
|
||||
equals: workflow.id
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
console.log(`Found ${runs.totalDocs} workflow runs`)
|
||||
if (runs.totalDocs > 0) {
|
||||
console.log('Run statuses:', runs.docs.map(r => r.status))
|
||||
}
|
||||
|
||||
// Should have exactly 1 run for the matching condition
|
||||
expect(runs.totalDocs).toBe(1)
|
||||
|
||||
// Check audit logs - should only have one for post2
|
||||
const auditLogs = await payload.find({
|
||||
collection: 'auditLog',
|
||||
where: {
|
||||
post: {
|
||||
equals: post2.id
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
if (runs.docs[0].status === 'completed') {
|
||||
expect(auditLogs.totalDocs).toBe(1)
|
||||
expect(auditLogs.docs[0].message).toBe('Condition was met and workflow triggered')
|
||||
}
|
||||
|
||||
// Verify no audit log for the first post
|
||||
const noAuditLogs = await payload.find({
|
||||
collection: 'auditLog',
|
||||
where: {
|
||||
post: {
|
||||
equals: post1.id
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
expect(noAuditLogs.totalDocs).toBe(0)
|
||||
|
||||
console.log('✅ Condition evaluation working with $.trigger.doc path!')
|
||||
}, 30000)
|
||||
})
|
||||
@@ -1,519 +0,0 @@
|
||||
import { describe, it, expect, beforeEach, afterEach } from 'vitest'
|
||||
import { getTestPayload, cleanDatabase } from './test-setup.js'
|
||||
import { mockHttpBin, testFixtures } from './test-helpers.js'
|
||||
|
||||
describe('Error Scenarios and Edge Cases', () => {
|
||||
|
||||
beforeEach(async () => {
|
||||
await cleanDatabase()
|
||||
// Set up comprehensive mocks for all error scenarios
|
||||
mockHttpBin.mockAllErrorScenarios()
|
||||
})
|
||||
|
||||
afterEach(async () => {
|
||||
await cleanDatabase()
|
||||
mockHttpBin.cleanup()
|
||||
})
|
||||
|
||||
it('should handle HTTP timeout errors gracefully', async () => {
|
||||
const payload = getTestPayload()
|
||||
|
||||
// Clear existing mocks and set up a proper timeout mock
|
||||
mockHttpBin.cleanup()
|
||||
mockHttpBin.mockTimeout()
|
||||
|
||||
const workflow = await payload.create({
|
||||
collection: 'workflows',
|
||||
data: {
|
||||
name: 'Test Error - HTTP Timeout',
|
||||
description: 'Tests HTTP request timeout handling',
|
||||
triggers: [
|
||||
{
|
||||
type: 'collection-trigger',
|
||||
collectionSlug: 'posts',
|
||||
operation: 'create'
|
||||
}
|
||||
],
|
||||
steps: [
|
||||
{
|
||||
...testFixtures.httpRequestStep('https://httpbin.org/delay/10'),
|
||||
name: 'timeout-request',
|
||||
method: 'GET',
|
||||
timeout: 2000, // 2 second timeout
|
||||
body: null
|
||||
}
|
||||
]
|
||||
}
|
||||
})
|
||||
|
||||
const post = await payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: 'Test Error Timeout Post'
|
||||
}
|
||||
})
|
||||
|
||||
// Wait for workflow execution (should timeout)
|
||||
await new Promise(resolve => setTimeout(resolve, 5000))
|
||||
|
||||
const runs = await payload.find({
|
||||
collection: 'workflow-runs',
|
||||
where: {
|
||||
workflow: {
|
||||
equals: workflow.id
|
||||
}
|
||||
},
|
||||
limit: 1
|
||||
})
|
||||
|
||||
expect(runs.totalDocs).toBe(1)
|
||||
// Either failed due to timeout or completed (depending on network speed)
|
||||
expect(['failed', 'completed']).toContain(runs.docs[0].status)
|
||||
|
||||
// Verify that detailed error information is preserved via new independent storage system
|
||||
const context = runs.docs[0].context
|
||||
const stepContext = context.steps['timeout-request']
|
||||
|
||||
// Check that independent execution info was recorded
|
||||
expect(stepContext.executionInfo).toBeDefined()
|
||||
expect(stepContext.executionInfo.completed).toBe(true)
|
||||
|
||||
// Check that detailed error information was preserved (new feature!)
|
||||
if (runs.docs[0].status === 'failed' && stepContext.errorDetails) {
|
||||
expect(stepContext.errorDetails.errorType).toBe('timeout')
|
||||
expect(stepContext.errorDetails.duration).toBeGreaterThan(2000)
|
||||
expect(stepContext.errorDetails.attempts).toBe(1)
|
||||
expect(stepContext.errorDetails.context.url).toBe('https://httpbin.org/delay/10')
|
||||
expect(stepContext.errorDetails.context.timeout).toBe(2000)
|
||||
console.log('✅ Detailed timeout error information preserved:', {
|
||||
errorType: stepContext.errorDetails.errorType,
|
||||
duration: stepContext.errorDetails.duration,
|
||||
attempts: stepContext.errorDetails.attempts
|
||||
})
|
||||
} else if (runs.docs[0].status === 'failed') {
|
||||
console.log('✅ Timeout error handled:', runs.docs[0].error)
|
||||
} else {
|
||||
console.log('✅ Request completed within timeout')
|
||||
}
|
||||
}, 15000)
|
||||
|
||||
it('should handle invalid JSON responses', async () => {
|
||||
const payload = getTestPayload()
|
||||
|
||||
const workflow = await payload.create({
|
||||
collection: 'workflows',
|
||||
data: {
|
||||
name: 'Test Error - Invalid JSON',
|
||||
description: 'Tests invalid JSON response handling',
|
||||
triggers: [
|
||||
{
|
||||
type: 'collection-trigger',
|
||||
collectionSlug: 'posts',
|
||||
operation: 'create'
|
||||
}
|
||||
],
|
||||
steps: [
|
||||
{
|
||||
name: 'invalid-json-request',
|
||||
step: 'http-request-step',
|
||||
url: 'https://httpbin.org/html', // Returns HTML, not JSON
|
||||
method: 'GET'
|
||||
}
|
||||
]
|
||||
}
|
||||
})
|
||||
|
||||
const post = await payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: 'Test Error Invalid JSON Post'
|
||||
}
|
||||
})
|
||||
|
||||
await new Promise(resolve => setTimeout(resolve, 5000))
|
||||
|
||||
const runs = await payload.find({
|
||||
collection: 'workflow-runs',
|
||||
where: {
|
||||
workflow: {
|
||||
equals: workflow.id
|
||||
}
|
||||
},
|
||||
limit: 1
|
||||
})
|
||||
|
||||
expect(runs.totalDocs).toBe(1)
|
||||
expect(runs.docs[0].status).toBe('completed') // Should complete but with HTML body
|
||||
expect(runs.docs[0].context.steps['invalid-json-request'].output.body).toContain('<html>')
|
||||
|
||||
console.log('✅ Non-JSON response handled correctly')
|
||||
}, 25000)
|
||||
|
||||
it('should handle circular reference in JSONPath resolution', async () => {
|
||||
const payload = getTestPayload()
|
||||
|
||||
// This test creates a scenario where JSONPath might encounter circular references
|
||||
const workflow = await payload.create({
|
||||
collection: 'workflows',
|
||||
data: {
|
||||
name: 'Test Error - Circular Reference',
|
||||
description: 'Tests circular reference handling in JSONPath',
|
||||
triggers: [
|
||||
{
|
||||
type: 'collection-trigger',
|
||||
collectionSlug: 'posts',
|
||||
operation: 'create'
|
||||
}
|
||||
],
|
||||
steps: [
|
||||
{
|
||||
name: 'circular-test',
|
||||
step: 'http-request-step',
|
||||
url: 'https://httpbin.org/post',
|
||||
method: 'POST',
|
||||
body: {
|
||||
// This creates a deep reference that could cause issues
|
||||
triggerData: '$.trigger',
|
||||
stepData: '$.steps',
|
||||
nestedRef: '$.trigger.doc'
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
})
|
||||
|
||||
const post = await payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: 'Test Error Circular Reference Post'
|
||||
}
|
||||
})
|
||||
|
||||
await new Promise(resolve => setTimeout(resolve, 5000))
|
||||
|
||||
const runs = await payload.find({
|
||||
collection: 'workflow-runs',
|
||||
where: {
|
||||
workflow: {
|
||||
equals: workflow.id
|
||||
}
|
||||
},
|
||||
limit: 1
|
||||
})
|
||||
|
||||
expect(runs.totalDocs).toBe(1)
|
||||
// Should either succeed with safe serialization or fail gracefully
|
||||
expect(['completed', 'failed']).toContain(runs.docs[0].status)
|
||||
|
||||
console.log('✅ Circular reference handled:', runs.docs[0].status)
|
||||
}, 20000)
|
||||
|
||||
it('should handle malformed workflow configurations', async () => {
|
||||
const payload = getTestPayload()
|
||||
|
||||
// This test should expect the workflow creation to fail due to validation
|
||||
let creationFailed = false
|
||||
let workflow: any = null
|
||||
|
||||
try {
|
||||
// Create workflow with missing required fields for create-document
|
||||
workflow = await payload.create({
|
||||
collection: 'workflows',
|
||||
data: {
|
||||
name: 'Test Error - Malformed Config',
|
||||
description: 'Tests malformed workflow configuration',
|
||||
triggers: [
|
||||
{
|
||||
type: 'collection-trigger',
|
||||
collectionSlug: 'posts',
|
||||
operation: 'create'
|
||||
}
|
||||
],
|
||||
steps: [
|
||||
{
|
||||
name: 'malformed-step',
|
||||
step: 'create-document',
|
||||
// Missing required collectionSlug
|
||||
data: {
|
||||
message: 'This should fail'
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
})
|
||||
} catch (error) {
|
||||
creationFailed = true
|
||||
expect(error).toBeDefined()
|
||||
console.log('✅ Workflow creation failed as expected:', error instanceof Error ? error.message : error)
|
||||
}
|
||||
|
||||
// If creation failed, that's the expected behavior
|
||||
if (creationFailed) {
|
||||
return
|
||||
}
|
||||
|
||||
// If somehow the workflow was created, test execution failure
|
||||
if (workflow) {
|
||||
const post = await payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: 'Test Error Malformed Config Post'
|
||||
}
|
||||
})
|
||||
|
||||
await new Promise(resolve => setTimeout(resolve, 3000))
|
||||
|
||||
const runs = await payload.find({
|
||||
collection: 'workflow-runs',
|
||||
where: {
|
||||
workflow: {
|
||||
equals: workflow.id
|
||||
}
|
||||
},
|
||||
limit: 1
|
||||
})
|
||||
|
||||
expect(runs.totalDocs).toBe(1)
|
||||
expect(runs.docs[0].status).toBe('failed')
|
||||
expect(runs.docs[0].error).toBeDefined()
|
||||
|
||||
console.log('✅ Malformed config caused execution failure:', runs.docs[0].error)
|
||||
}
|
||||
}, 15000)
|
||||
|
||||
it('should handle HTTP 4xx and 5xx errors properly', async () => {
|
||||
const payload = getTestPayload()
|
||||
|
||||
const workflow = await payload.create({
|
||||
collection: 'workflows',
|
||||
data: {
|
||||
name: 'Test Error - HTTP Errors',
|
||||
description: 'Tests HTTP error status handling',
|
||||
triggers: [
|
||||
{
|
||||
type: 'collection-trigger',
|
||||
collectionSlug: 'posts',
|
||||
operation: 'create'
|
||||
}
|
||||
],
|
||||
steps: [
|
||||
{
|
||||
name: 'not-found-request',
|
||||
step: 'http-request-step',
|
||||
url: 'https://httpbin.org/status/404',
|
||||
method: 'GET'
|
||||
},
|
||||
{
|
||||
name: 'server-error-request',
|
||||
step: 'http-request-step',
|
||||
url: 'https://httpbin.org/status/500',
|
||||
method: 'GET',
|
||||
dependencies: ['not-found-request']
|
||||
}
|
||||
]
|
||||
}
|
||||
})
|
||||
|
||||
const post = await payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: 'Test Error HTTP Status Post'
|
||||
}
|
||||
})
|
||||
|
||||
await new Promise(resolve => setTimeout(resolve, 8000))
|
||||
|
||||
const runs = await payload.find({
|
||||
collection: 'workflow-runs',
|
||||
where: {
|
||||
workflow: {
|
||||
equals: workflow.id
|
||||
}
|
||||
},
|
||||
limit: 1
|
||||
})
|
||||
|
||||
expect(runs.totalDocs).toBe(1)
|
||||
expect(runs.docs[0].status).toBe('completed') // Workflow should complete successfully
|
||||
|
||||
// Check that both steps completed with HTTP error outputs
|
||||
const context = runs.docs[0].context
|
||||
expect(context.steps['not-found-request'].state).toBe('succeeded') // HTTP request completed
|
||||
expect(context.steps['not-found-request'].output.status).toBe(404) // But with error status
|
||||
|
||||
console.log('✅ HTTP error statuses handled correctly')
|
||||
}, 25000)
|
||||
|
||||
it('should handle retry logic for transient failures', async () => {
|
||||
const payload = getTestPayload()
|
||||
|
||||
const workflow = await payload.create({
|
||||
collection: 'workflows',
|
||||
data: {
|
||||
name: 'Test Error - Retry Logic',
|
||||
description: 'Tests retry logic for HTTP requests',
|
||||
triggers: [
|
||||
{
|
||||
type: 'collection-trigger',
|
||||
collectionSlug: 'posts',
|
||||
operation: 'create'
|
||||
}
|
||||
],
|
||||
steps: [
|
||||
{
|
||||
name: 'retry-request',
|
||||
step: 'http-request-step',
|
||||
url: 'https://httpbin.org/status/503', // Service unavailable
|
||||
method: 'GET',
|
||||
retries: 3,
|
||||
retryDelay: 1000
|
||||
}
|
||||
]
|
||||
}
|
||||
})
|
||||
|
||||
const post = await payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: 'Test Error Retry Logic Post'
|
||||
}
|
||||
})
|
||||
|
||||
await new Promise(resolve => setTimeout(resolve, 10000))
|
||||
|
||||
const runs = await payload.find({
|
||||
collection: 'workflow-runs',
|
||||
where: {
|
||||
workflow: {
|
||||
equals: workflow.id
|
||||
}
|
||||
},
|
||||
limit: 1
|
||||
})
|
||||
|
||||
expect(runs.totalDocs).toBe(1)
|
||||
expect(runs.docs[0].status).toBe('completed') // Workflow should complete with HTTP error output
|
||||
|
||||
// The step should have succeeded but with error status
|
||||
const stepContext = runs.docs[0].context.steps['retry-request']
|
||||
expect(stepContext.state).toBe('succeeded')
|
||||
expect(stepContext.output.status).toBe(503)
|
||||
|
||||
console.log('✅ Retry logic executed correctly')
|
||||
}, 25000)
|
||||
|
||||
it('should handle extremely large workflow contexts', async () => {
|
||||
const payload = getTestPayload()
|
||||
|
||||
const workflow = await payload.create({
|
||||
collection: 'workflows',
|
||||
data: {
|
||||
name: 'Test Error - Large Context',
|
||||
description: 'Tests handling of large workflow contexts',
|
||||
triggers: [
|
||||
{
|
||||
type: 'collection-trigger',
|
||||
collectionSlug: 'posts',
|
||||
operation: 'create'
|
||||
}
|
||||
],
|
||||
steps: [
|
||||
{
|
||||
name: 'large-response-request',
|
||||
step: 'http-request-step',
|
||||
url: 'https://httpbin.org/base64/SFRUUEJJTiBpcyBhd2Vzb21l', // Returns base64 decoded text
|
||||
method: 'GET'
|
||||
}
|
||||
]
|
||||
}
|
||||
})
|
||||
|
||||
const post = await payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: 'Test Error Large Context Post'
|
||||
}
|
||||
})
|
||||
|
||||
await new Promise(resolve => setTimeout(resolve, 5000))
|
||||
|
||||
const runs = await payload.find({
|
||||
collection: 'workflow-runs',
|
||||
where: {
|
||||
workflow: {
|
||||
equals: workflow.id
|
||||
}
|
||||
},
|
||||
limit: 1
|
||||
})
|
||||
|
||||
expect(runs.totalDocs).toBe(1)
|
||||
// Should handle large contexts without memory issues
|
||||
expect(['completed', 'failed']).toContain(runs.docs[0].status)
|
||||
|
||||
console.log('✅ Large context handled:', runs.docs[0].status)
|
||||
}, 20000)
|
||||
|
||||
it('should handle undefined and null values in JSONPath', async () => {
|
||||
const payload = getTestPayload()
|
||||
|
||||
const workflow = await payload.create({
|
||||
collection: 'workflows',
|
||||
data: {
|
||||
name: 'Test Error - Null Values',
|
||||
description: 'Tests null/undefined values in JSONPath expressions',
|
||||
triggers: [
|
||||
{
|
||||
type: 'collection-trigger',
|
||||
collectionSlug: 'posts',
|
||||
operation: 'create'
|
||||
}
|
||||
],
|
||||
steps: [
|
||||
{
|
||||
name: 'null-value-request',
|
||||
step: 'http-request-step',
|
||||
url: 'https://httpbin.org/post',
|
||||
method: 'POST',
|
||||
body: {
|
||||
nonexistentField: '$.trigger.doc.nonexistent',
|
||||
nullField: '$.trigger.doc.null',
|
||||
undefinedField: '$.trigger.doc.undefined'
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
})
|
||||
|
||||
const post = await payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: 'Test Error Null Values Post'
|
||||
}
|
||||
})
|
||||
|
||||
await new Promise(resolve => setTimeout(resolve, 5000))
|
||||
|
||||
const runs = await payload.find({
|
||||
collection: 'workflow-runs',
|
||||
where: {
|
||||
workflow: {
|
||||
equals: workflow.id
|
||||
}
|
||||
},
|
||||
limit: 1
|
||||
})
|
||||
|
||||
expect(runs.totalDocs).toBe(1)
|
||||
// Should handle null/undefined values gracefully
|
||||
expect(['completed', 'failed']).toContain(runs.docs[0].status)
|
||||
|
||||
if (runs.docs[0].status === 'completed') {
|
||||
const stepOutput = runs.docs[0].context.steps['null-value-request'].output
|
||||
expect(stepOutput.status).toBe(200) // httpbin should accept the request
|
||||
console.log('✅ Null values handled gracefully')
|
||||
} else {
|
||||
console.log('✅ Null values caused expected failure:', runs.docs[0].error)
|
||||
}
|
||||
}, 20000)
|
||||
})
|
||||
@@ -1,392 +0,0 @@
|
||||
import { describe, it, expect, beforeEach, afterEach } from 'vitest'
|
||||
import { getTestPayload, cleanDatabase } from './test-setup.js'
|
||||
import { mockHttpBin, testFixtures } from './test-helpers.js'
|
||||
|
||||
describe('Hook Execution Reliability Tests', () => {
|
||||
|
||||
beforeEach(async () => {
|
||||
await cleanDatabase()
|
||||
})
|
||||
|
||||
afterEach(async () => {
|
||||
await cleanDatabase()
|
||||
mockHttpBin.cleanup()
|
||||
})
|
||||
|
||||
it('should reliably execute hooks when collections are created', async () => {
|
||||
const payload = getTestPayload()
|
||||
|
||||
// Create a workflow with collection trigger
|
||||
const workflow = await payload.create({
|
||||
collection: 'workflows',
|
||||
data: {
|
||||
name: 'Test Hook Reliability - Create',
|
||||
description: 'Tests hook execution on post creation',
|
||||
triggers: [
|
||||
{
|
||||
type: 'collection-trigger',
|
||||
collectionSlug: 'posts',
|
||||
operation: 'create'
|
||||
}
|
||||
],
|
||||
steps: [
|
||||
{
|
||||
...testFixtures.createDocumentStep('auditLog'),
|
||||
name: 'create-audit-log',
|
||||
data: {
|
||||
message: 'Post was created via workflow trigger',
|
||||
post: '$.trigger.doc.id'
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
})
|
||||
|
||||
expect(workflow).toBeDefined()
|
||||
expect(workflow.id).toBeDefined()
|
||||
|
||||
// Create a post to trigger the workflow
|
||||
const post = await payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: 'Test Hook Reliability Post'
|
||||
}
|
||||
})
|
||||
|
||||
expect(post).toBeDefined()
|
||||
|
||||
// Wait for workflow execution
|
||||
await new Promise(resolve => setTimeout(resolve, 5000))
|
||||
|
||||
// Verify workflow run was created
|
||||
const runs = await payload.find({
|
||||
collection: 'workflow-runs',
|
||||
where: {
|
||||
workflow: {
|
||||
equals: workflow.id
|
||||
}
|
||||
},
|
||||
limit: 1
|
||||
})
|
||||
|
||||
expect(runs.totalDocs).toBe(1)
|
||||
// Either succeeded or failed, but should have executed
|
||||
expect(['completed', 'failed']).toContain(runs.docs[0].status)
|
||||
|
||||
console.log('✅ Hook execution status:', runs.docs[0].status)
|
||||
|
||||
// Verify audit log was created only if the workflow succeeded
|
||||
if (runs.docs[0].status === 'completed') {
|
||||
const auditLogs = await payload.find({
|
||||
collection: 'auditLog',
|
||||
where: {
|
||||
post: {
|
||||
equals: post.id
|
||||
}
|
||||
},
|
||||
limit: 1
|
||||
})
|
||||
|
||||
expect(auditLogs.totalDocs).toBeGreaterThan(0)
|
||||
expect(auditLogs.docs[0].message).toContain('workflow trigger')
|
||||
} else {
|
||||
// If workflow failed, just log the error but don't fail the test
|
||||
console.log('⚠️ Workflow failed:', runs.docs[0].error)
|
||||
// The important thing is that a workflow run was created
|
||||
}
|
||||
}, 30000)
|
||||
|
||||
it('should handle hook execution errors gracefully', async () => {
|
||||
const payload = getTestPayload()
|
||||
|
||||
// Mock network error for invalid URL
|
||||
mockHttpBin.mockNetworkError('invalid-url-that-will-fail')
|
||||
|
||||
// Create a workflow with invalid step configuration
|
||||
const workflow = await payload.create({
|
||||
collection: 'workflows',
|
||||
data: {
|
||||
name: 'Test Hook Error Handling',
|
||||
description: 'Tests error handling in hook execution',
|
||||
triggers: [
|
||||
{
|
||||
type: 'collection-trigger',
|
||||
collectionSlug: 'posts',
|
||||
operation: 'create'
|
||||
}
|
||||
],
|
||||
steps: [
|
||||
{
|
||||
name: 'invalid-http-request',
|
||||
step: 'http-request-step',
|
||||
url: 'https://invalid-url-that-will-fail',
|
||||
method: 'GET'
|
||||
}
|
||||
]
|
||||
}
|
||||
})
|
||||
|
||||
// Create a post to trigger the workflow
|
||||
const post = await payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: 'Test Hook Error Handling Post'
|
||||
}
|
||||
})
|
||||
|
||||
// Wait for workflow execution
|
||||
await new Promise(resolve => setTimeout(resolve, 5000))
|
||||
|
||||
// Verify a failed workflow run was created
|
||||
const runs = await payload.find({
|
||||
collection: 'workflow-runs',
|
||||
where: {
|
||||
workflow: {
|
||||
equals: workflow.id
|
||||
}
|
||||
},
|
||||
limit: 1
|
||||
})
|
||||
|
||||
expect(runs.totalDocs).toBe(1)
|
||||
expect(runs.docs[0].status).toBe('failed')
|
||||
expect(runs.docs[0].error).toBeDefined()
|
||||
// Check that the error mentions either the URL or the task failure
|
||||
const errorMessage = runs.docs[0].error.toLowerCase()
|
||||
const hasRelevantError = errorMessage.includes('url') ||
|
||||
errorMessage.includes('invalid-url') ||
|
||||
errorMessage.includes('network') ||
|
||||
errorMessage.includes('failed')
|
||||
expect(hasRelevantError).toBe(true)
|
||||
|
||||
console.log('✅ Error handling working:', runs.docs[0].error)
|
||||
}, 30000)
|
||||
|
||||
it('should create failed workflow runs when executor is unavailable', async () => {
|
||||
const payload = getTestPayload()
|
||||
|
||||
// This test simulates the executor being unavailable
|
||||
// We'll create a workflow and then simulate a hook execution without proper executor
|
||||
const workflow = await payload.create({
|
||||
collection: 'workflows',
|
||||
data: {
|
||||
name: 'Test Hook Executor Unavailable',
|
||||
description: 'Tests handling when executor is not available',
|
||||
triggers: [
|
||||
{
|
||||
type: 'collection-trigger',
|
||||
collectionSlug: 'posts',
|
||||
operation: 'create'
|
||||
}
|
||||
],
|
||||
steps: [
|
||||
{
|
||||
name: 'simple-step',
|
||||
step: 'http-request-step',
|
||||
url: 'https://httpbin.org/get'
|
||||
}
|
||||
]
|
||||
}
|
||||
})
|
||||
|
||||
// Temporarily disable the executor by setting it to null
|
||||
// This simulates the initialization issue
|
||||
const global = globalThis as any
|
||||
const originalExecutor = global.__workflowExecutor
|
||||
global.__workflowExecutor = null
|
||||
|
||||
try {
|
||||
// Create a post to trigger the workflow
|
||||
const post = await payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: 'Test Hook Executor Unavailable Post'
|
||||
}
|
||||
})
|
||||
|
||||
// Wait for hook execution attempt
|
||||
await new Promise(resolve => setTimeout(resolve, 3000))
|
||||
|
||||
// Verify a failed workflow run was created for executor unavailability
|
||||
const runs = await payload.find({
|
||||
collection: 'workflow-runs',
|
||||
where: {
|
||||
workflow: {
|
||||
equals: workflow.id
|
||||
}
|
||||
},
|
||||
limit: 1
|
||||
})
|
||||
|
||||
if (runs.totalDocs > 0) {
|
||||
expect(runs.docs[0].error).toBeDefined()
|
||||
console.log('✅ Executor unavailable error captured:', runs.docs[0].error)
|
||||
} else {
|
||||
console.log('⚠️ No workflow run created - this indicates the hook may not have executed')
|
||||
}
|
||||
} finally {
|
||||
// Restore the original executor
|
||||
global.__workflowExecutor = originalExecutor
|
||||
}
|
||||
}, 30000)
|
||||
|
||||
it('should handle workflow conditions properly', async () => {
|
||||
const payload = getTestPayload()
|
||||
|
||||
// Create a workflow with a condition that should prevent execution
|
||||
const workflow = await payload.create({
|
||||
collection: 'workflows',
|
||||
data: {
|
||||
name: 'Test Hook Conditional Execution',
|
||||
description: 'Tests conditional workflow execution',
|
||||
triggers: [
|
||||
{
|
||||
type: 'collection-trigger',
|
||||
collectionSlug: 'posts',
|
||||
operation: 'create',
|
||||
condition: '$.trigger.doc.content == "TRIGGER_CONDITION"'
|
||||
}
|
||||
],
|
||||
steps: [
|
||||
{
|
||||
name: 'conditional-audit',
|
||||
step: 'create-document',
|
||||
collectionSlug: 'auditLog',
|
||||
data: {
|
||||
post: '$.trigger.doc.id',
|
||||
message: 'Conditional trigger executed'
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
})
|
||||
|
||||
// Create a post that SHOULD NOT trigger the workflow
|
||||
const post1 = await payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: 'Test Hook Conditional - Should Not Trigger'
|
||||
}
|
||||
})
|
||||
|
||||
// Create a post that SHOULD trigger the workflow
|
||||
const post2 = await payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: 'TRIGGER_CONDITION'
|
||||
}
|
||||
})
|
||||
|
||||
// Wait for workflow execution
|
||||
await new Promise(resolve => setTimeout(resolve, 5000))
|
||||
|
||||
// Check workflow runs
|
||||
const runs = await payload.find({
|
||||
collection: 'workflow-runs',
|
||||
where: {
|
||||
workflow: {
|
||||
equals: workflow.id
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
// Should have exactly 1 run (only for the matching condition)
|
||||
expect(runs.totalDocs).toBe(1)
|
||||
// Either succeeded or failed, but should have executed
|
||||
expect(['completed', 'failed']).toContain(runs.docs[0].status)
|
||||
|
||||
// Verify audit log was created only for the correct post
|
||||
const auditLogs = await payload.find({
|
||||
collection: 'auditLog',
|
||||
where: {
|
||||
post: {
|
||||
equals: post2.id
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
expect(auditLogs.totalDocs).toBe(1)
|
||||
|
||||
// Verify no audit log for the first post
|
||||
const noAuditLogs = await payload.find({
|
||||
collection: 'auditLog',
|
||||
where: {
|
||||
post: {
|
||||
equals: post1.id
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
expect(noAuditLogs.totalDocs).toBe(0)
|
||||
|
||||
console.log('✅ Conditional execution working correctly')
|
||||
}, 30000)
|
||||
|
||||
it('should handle multiple concurrent hook executions', async () => {
|
||||
const payload = getTestPayload()
|
||||
|
||||
// Create a workflow
|
||||
const workflow = await payload.create({
|
||||
collection: 'workflows',
|
||||
data: {
|
||||
name: 'Test Hook Concurrent Execution',
|
||||
description: 'Tests handling multiple concurrent hook executions',
|
||||
triggers: [
|
||||
{
|
||||
type: 'collection-trigger',
|
||||
collectionSlug: 'posts',
|
||||
operation: 'create'
|
||||
}
|
||||
],
|
||||
steps: [
|
||||
{
|
||||
name: 'concurrent-audit',
|
||||
step: 'create-document',
|
||||
collectionSlug: 'auditLog',
|
||||
data: {
|
||||
post: '$.trigger.doc.id',
|
||||
message: 'Concurrent execution test'
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
})
|
||||
|
||||
// Create multiple posts concurrently
|
||||
const concurrentCreations = Array.from({ length: 5 }, (_, i) =>
|
||||
payload.create({
|
||||
collection: 'posts',
|
||||
data: {
|
||||
content: `Test Hook Concurrent Post ${i + 1}`
|
||||
}
|
||||
})
|
||||
)
|
||||
|
||||
const posts = await Promise.all(concurrentCreations)
|
||||
expect(posts).toHaveLength(5)
|
||||
|
||||
// Wait for all workflow executions
|
||||
await new Promise(resolve => setTimeout(resolve, 8000))
|
||||
|
||||
// Verify all workflow runs were created
|
||||
const runs = await payload.find({
|
||||
collection: 'workflow-runs',
|
||||
where: {
|
||||
workflow: {
|
||||
equals: workflow.id
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
expect(runs.totalDocs).toBe(5)
|
||||
|
||||
// Verify all runs completed successfully
|
||||
const failedRuns = runs.docs.filter(run => run.status === 'failed')
|
||||
expect(failedRuns).toHaveLength(0)
|
||||
|
||||
console.log('✅ Concurrent executions completed:', {
|
||||
totalRuns: runs.totalDocs,
|
||||
statuses: runs.docs.map(run => run.status)
|
||||
})
|
||||
}, 45000)
|
||||
})
|
||||
@@ -1,94 +0,0 @@
|
||||
import { describe, it, expect, beforeEach, afterEach } from 'vitest'
|
||||
import { getTestPayload, cleanDatabase } from './test-setup.js'
|
||||
import { mockHttpBin, testFixtures } from './test-helpers.js'
|
||||
|
||||
describe('Workflow Trigger Test', () => {
|
||||
|
||||
beforeEach(async () => {
|
||||
await cleanDatabase()
|
||||
// Set up HTTP mocks
|
||||
const expectedRequestData = {
|
||||
message: 'Post created',
|
||||
postId: expect.any(String), // MongoDB ObjectId
|
||||
postTitle: 'Test post content for workflow trigger'
|
||||
}
|
||||
mockHttpBin.mockPost(expectedRequestData)
|
||||
})
|
||||
|
||||
afterEach(async () => {
|
||||
await cleanDatabase()
|
||||
mockHttpBin.cleanup()
|
||||
})
|
||||
|
||||
it('should create a workflow run when a post is created', async () => {
|
||||
const payload = getTestPayload()
|
||||
|
||||
// Use test fixtures for consistent data
|
||||
const testWorkflow = {
|
||||
...testFixtures.basicWorkflow,
|
||||
name: 'Test Post Creation Workflow',
|
||||
description: 'Triggers when a post is created',
|
||||
steps: [
|
||||
{
|
||||
...testFixtures.httpRequestStep(),
|
||||
name: 'log-post',
|
||||
body: {
|
||||
message: 'Post created',
|
||||
postId: '$.trigger.doc.id',
|
||||
postTitle: '$.trigger.doc.content'
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
|
||||
// Create a workflow with collection trigger
|
||||
const workflow = await payload.create({
|
||||
collection: 'workflows',
|
||||
data: testWorkflow
|
||||
})
|
||||
|
||||
expect(workflow).toBeDefined()
|
||||
expect(workflow.id).toBeDefined()
|
||||
|
||||
// Create a post to trigger the workflow
|
||||
const post = await payload.create({
|
||||
collection: 'posts',
|
||||
data: testFixtures.testPost
|
||||
})
|
||||
|
||||
expect(post).toBeDefined()
|
||||
expect(post.id).toBeDefined()
|
||||
|
||||
// Wait a bit for workflow to execute
|
||||
await new Promise(resolve => setTimeout(resolve, 3000))
|
||||
|
||||
// Check for workflow runs
|
||||
const runs = await payload.find({
|
||||
collection: 'workflow-runs',
|
||||
where: {
|
||||
workflow: {
|
||||
equals: workflow.id
|
||||
}
|
||||
},
|
||||
limit: 10
|
||||
})
|
||||
|
||||
expect(runs.totalDocs).toBeGreaterThan(0)
|
||||
|
||||
// Check if workflow is an object or ID
|
||||
const workflowRef = runs.docs[0].workflow
|
||||
const workflowId = typeof workflowRef === 'object' && workflowRef !== null
|
||||
? (workflowRef as any).id
|
||||
: workflowRef
|
||||
|
||||
expect(workflowId).toBe(workflow.id) // Should reference the workflow ID
|
||||
|
||||
console.log('✅ Workflow run created successfully!')
|
||||
console.log(`Run status: ${runs.docs[0].status}`)
|
||||
console.log(`Run ID: ${runs.docs[0].id}`)
|
||||
|
||||
if (runs.docs[0].status === 'failed' && runs.docs[0].error) {
|
||||
console.log(`Error: ${runs.docs[0].error}`)
|
||||
}
|
||||
}, 30000)
|
||||
})
|
||||
@@ -159,39 +159,54 @@ export const mockHttpBin = {
|
||||
* Test fixtures for common workflow configurations
|
||||
*/
|
||||
export const testFixtures = {
|
||||
// Function to create workflow data that bypasses parameter validation
|
||||
createWorkflow: async (payload: any, workflowData: any) => {
|
||||
// Insert directly into database to bypass parameter field validation
|
||||
const result = await payload.db.create({
|
||||
collection: 'workflows',
|
||||
data: workflowData
|
||||
})
|
||||
return result
|
||||
},
|
||||
basicWorkflow: {
|
||||
name: 'Test Basic Workflow',
|
||||
description: 'Basic workflow for testing',
|
||||
triggers: [
|
||||
{
|
||||
type: 'collection-trigger' as const,
|
||||
collectionSlug: 'posts',
|
||||
operation: 'create' as const
|
||||
type: 'collection-hook' as const,
|
||||
parameters: {
|
||||
collectionSlug: 'posts',
|
||||
hook: 'afterChange'
|
||||
}
|
||||
}
|
||||
]
|
||||
},
|
||||
|
||||
httpRequestStep: (url: string = 'https://httpbin.org/post', expectedData?: any) => ({
|
||||
name: 'http-request',
|
||||
step: 'http-request-step',
|
||||
url,
|
||||
method: 'POST' as const,
|
||||
headers: {
|
||||
'Content-Type': 'application/json'
|
||||
},
|
||||
body: expectedData || {
|
||||
message: 'Test request',
|
||||
data: '$.trigger.doc'
|
||||
type: 'http-request-step',
|
||||
parameters: {
|
||||
url,
|
||||
method: 'POST',
|
||||
headers: {
|
||||
'Content-Type': 'application/json'
|
||||
},
|
||||
body: expectedData || {
|
||||
message: 'Test request',
|
||||
data: '$.trigger.doc'
|
||||
}
|
||||
}
|
||||
}),
|
||||
|
||||
createDocumentStep: (collectionSlug: string = 'auditLog') => ({
|
||||
name: 'create-audit',
|
||||
step: 'create-document',
|
||||
collectionSlug,
|
||||
data: {
|
||||
message: 'Test document created',
|
||||
sourceId: '$.trigger.doc.id'
|
||||
type: 'create-document',
|
||||
parameters: {
|
||||
collectionSlug,
|
||||
data: {
|
||||
message: 'Test document created',
|
||||
sourceId: '$.trigger.doc.id'
|
||||
}
|
||||
}
|
||||
}),
|
||||
|
||||
|
||||
Reference in New Issue
Block a user