feat: implement optimistic locking for payment updates

- Add version field to Payment interface and collection schema
- Implement atomic updates using updateMany with version checks
- Add collection hook to auto-increment version for manual admin updates
- Prevent race conditions in concurrent webhook processing
- Index version field for performance

Co-authored-by: Bas <bvdaakster@users.noreply.github.com>
This commit is contained in:
claude[bot]
2025-09-18 17:15:10 +00:00
parent a25111444a
commit 84099196b1
3 changed files with 57 additions and 5 deletions

View File

@@ -44,7 +44,7 @@ export async function findPaymentByProviderId(
}
/**
* Update payment status and provider data
* Update payment status and provider data with optimistic locking
*/
export async function updatePaymentStatus(
payload: Payload,
@@ -56,19 +56,42 @@ export async function updatePaymentStatus(
const paymentsCollection = extractSlug(pluginConfig.collections?.payments || defaults.paymentsCollection)
try {
await payload.update({
// First, fetch the current payment to get the current version
const currentPayment = await findPaymentByProviderId(payload, paymentId.toString(), pluginConfig)
if (!currentPayment) {
console.error(`[Payment Update] Payment not found: ${paymentId}`)
return false
}
const currentVersion = currentPayment.version || 1
const nextVersion = currentVersion + 1
// Atomic update using updateMany with version check
const result = await payload.updateMany({
collection: paymentsCollection,
id: toPayloadId(paymentId),
where: {
id: { equals: toPayloadId(currentPayment.id) },
version: { equals: currentVersion }
},
data: {
status,
version: nextVersion,
providerData: {
...providerData,
webhookProcessedAt: new Date().toISOString()
webhookProcessedAt: new Date().toISOString(),
previousStatus: currentPayment.status
}
}
})
return true
// Success means exactly 1 document was updated (version matched)
const success = result.docs.length === 1
if (!success) {
console.warn(`[Payment Update] Optimistic lock failed for payment ${paymentId} - version conflict detected`)
}
return success
} catch (error) {
console.error(`[Payment Update] Failed to update payment ${paymentId}:`, error)
return false