Merge pull request #14 from xtr-dev/dev

Dev
This commit is contained in:
Bas
2025-10-03 20:06:39 +02:00
committed by GitHub
4 changed files with 71 additions and 123 deletions

4
package-lock.json generated
View File

@@ -1,12 +1,12 @@
{ {
"name": "payload-feature-flags", "name": "payload-feature-flags",
"version": "0.0.17", "version": "0.0.18",
"lockfileVersion": 3, "lockfileVersion": 3,
"requires": true, "requires": true,
"packages": { "packages": {
"": { "": {
"name": "payload-feature-flags", "name": "payload-feature-flags",
"version": "0.0.17", "version": "0.0.18",
"license": "MIT", "license": "MIT",
"devDependencies": { "devDependencies": {
"@eslint/eslintrc": "^3.2.0", "@eslint/eslintrc": "^3.2.0",

View File

@@ -1,6 +1,6 @@
{ {
"name": "@xtr-dev/payload-feature-flags", "name": "@xtr-dev/payload-feature-flags",
"version": "0.0.17", "version": "0.0.18",
"description": "Feature flags plugin for Payload CMS - manage feature toggles, A/B tests, and gradual rollouts", "description": "Feature flags plugin for Payload CMS - manage feature toggles, A/B tests, and gradual rollouts",
"license": "MIT", "license": "MIT",
"type": "module", "type": "module",

View File

@@ -1,4 +1,6 @@
'use client' 'use client'
import React from 'react'
import type { ListViewClientProps } from 'payload'
import { useState, useEffect, useCallback, useMemo, memo } from 'react' import { useState, useEffect, useCallback, useMemo, memo } from 'react'
import { import {
useConfig, useConfig,

View File

@@ -1,19 +1,13 @@
import type { AdminViewServerProps } from 'payload' import React from 'react'
import { DefaultTemplate } from '@payloadcms/next/templates' import type { ListViewServerProps } from 'payload'
import { Gutter } from '@payloadcms/ui'
import FeatureFlagsClient from './FeatureFlagsClient.js' import FeatureFlagsClient from './FeatureFlagsClient.js'
import type { FeatureFlag } from '../types/index.js' import type { FeatureFlag } from '../types/index.js'
async function fetchInitialFlags(payload: any, searchParams?: Record<string, any>): Promise<FeatureFlag[]> { async function fetchInitialFlags(payload: any, collectionSlug: string): Promise<FeatureFlag[]> {
try { try {
const limit = Math.min(1000, parseInt(searchParams?.limit as string) || 100)
const page = Math.max(1, parseInt(searchParams?.page as string) || 1)
const collectionSlug = searchParams?.collectionSlug as string || 'feature-flags'
const result = await payload.find({ const result = await payload.find({
collection: collectionSlug, collection: collectionSlug,
limit, limit: 1000,
page,
sort: 'name', sort: 'name',
}) })
@@ -24,30 +18,12 @@ async function fetchInitialFlags(payload: any, searchParams?: Record<string, any
} }
} }
export default async function FeatureFlagsView({ export default async function FeatureFlagsView(props: ListViewServerProps) {
initPageResult, const { collectionConfig, user, permissions, payload } = props
params,
searchParams,
}: AdminViewServerProps) {
const {
req: { user },
permissions,
} = initPageResult
// Security check: User must be logged in // Security check: User must be logged in
if (!user) { if (!user) {
return ( return (
<DefaultTemplate
i18n={initPageResult.req.i18n}
locale={initPageResult.locale}
params={params}
payload={initPageResult.req.payload}
permissions={initPageResult.permissions}
searchParams={searchParams}
user={undefined}
visibleEntities={initPageResult.visibleEntities}
>
<Gutter>
<div style={{ <div style={{
padding: '2rem', padding: '2rem',
textAlign: 'center', textAlign: 'center',
@@ -78,27 +54,13 @@ export default async function FeatureFlagsView({
Go to Login Go to Login
</a> </a>
</div> </div>
</Gutter>
</DefaultTemplate>
) )
} }
// Security check: User must have permissions to access feature-flags collection // Security check: User must have permissions to access the collection
const collectionSlug = searchParams?.collectionSlug as string || 'feature-flags' const canReadFeatureFlags = permissions?.collections?.[collectionConfig.slug]?.read
const canReadFeatureFlags = permissions?.collections?.[collectionSlug]?.read
if (!canReadFeatureFlags) { if (!canReadFeatureFlags) {
return ( return (
<DefaultTemplate
i18n={initPageResult.req.i18n}
locale={initPageResult.locale}
params={params}
payload={initPageResult.req.payload}
permissions={initPageResult.permissions}
searchParams={searchParams}
user={initPageResult.req.user || undefined}
visibleEntities={initPageResult.visibleEntities}
>
<Gutter>
<div style={{ <div style={{
padding: '2rem', padding: '2rem',
textAlign: 'center', textAlign: 'center',
@@ -115,40 +77,24 @@ export default async function FeatureFlagsView({
You don't have permission to access the Feature Flags Dashboard. You don't have permission to access the Feature Flags Dashboard.
</p> </p>
<p style={{ fontSize: '0.875rem', color: 'var(--theme-warning-600)' }}> <p style={{ fontSize: '0.875rem', color: 'var(--theme-warning-600)' }}>
Contact your administrator to request access to the feature-flags collection. Contact your administrator to request access to the {collectionConfig.slug} collection.
</p> </p>
</div> </div>
</Gutter>
</DefaultTemplate>
) )
} }
// Fetch initial data server-side (only if user has access) // Fetch initial data server-side (only if user has access)
const initialFlags = await fetchInitialFlags(initPageResult.req.payload, searchParams) const initialFlags = await fetchInitialFlags(payload, collectionConfig.slug)
// Check if user can update feature flags (use already defined collection slug) // Check if user can update feature flags
const canUpdateFeatureFlags = permissions?.collections?.[collectionSlug]?.update || false const canUpdateFeatureFlags = permissions?.collections?.[collectionConfig.slug]?.update || false
// Use DefaultTemplate with proper props structure from initPageResult
return ( return (
<DefaultTemplate
i18n={initPageResult.req.i18n}
locale={initPageResult.locale}
params={params}
payload={initPageResult.req.payload}
permissions={initPageResult.permissions}
searchParams={searchParams}
user={initPageResult.req.user || undefined}
visibleEntities={initPageResult.visibleEntities}
>
<Gutter>
<FeatureFlagsClient <FeatureFlagsClient
initialFlags={initialFlags} initialFlags={initialFlags}
canUpdate={canUpdateFeatureFlags} canUpdate={canUpdateFeatureFlags}
maxFlags={parseInt(searchParams?.maxFlags as string) || 100} maxFlags={100}
collectionSlug={collectionSlug} collectionSlug={collectionConfig.slug}
/> />
</Gutter>
</DefaultTemplate>
) )
} }