mirror of
https://github.com/xtr-dev/payload-mailing.git
synced 2025-12-10 08:13:23 +00:00
Fix workflow to run as required status check before merge
### 🚀 Features - Added `validate` job that runs on version branch PRs as required status check - Added pre-merge validation with tests, build, and branch type detection ### 🐛 Bug Fixes - Fixed workflow timing: now blocks PR merge until validation passes - Changed trigger from `types: [closed]` to `types: [opened, synchronize, reopened]` - Separated validation (PR) from publishing (post-merge) workflows ### 🔧 Improvements - Version publishing only runs after successful merge to main - Clear messaging about release type during PR validation - Prevents immediate PR closure before workflow completion 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
55
.github/workflows/version-and-publish.yml
vendored
55
.github/workflows/version-and-publish.yml
vendored
@@ -7,11 +7,60 @@ on:
|
|||||||
pull_request:
|
pull_request:
|
||||||
branches:
|
branches:
|
||||||
- main
|
- main
|
||||||
types: [closed]
|
types: [opened, synchronize, reopened]
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
|
validate:
|
||||||
|
if: github.event_name == 'pull_request' && (startsWith(github.event.pull_request.head.ref, 'major/') || startsWith(github.event.pull_request.head.ref, 'minor/') || startsWith(github.event.pull_request.head.ref, 'patch/'))
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
steps:
|
||||||
|
- name: Checkout code
|
||||||
|
uses: actions/checkout@v4
|
||||||
|
|
||||||
|
- name: Setup Node.js
|
||||||
|
uses: actions/setup-node@v4
|
||||||
|
with:
|
||||||
|
node-version: '20'
|
||||||
|
|
||||||
|
- name: Setup pnpm
|
||||||
|
uses: pnpm/action-setup@v4
|
||||||
|
with:
|
||||||
|
version: 8
|
||||||
|
|
||||||
|
- name: Get pnpm store directory
|
||||||
|
shell: bash
|
||||||
|
run: echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
|
||||||
|
|
||||||
|
- name: Setup pnpm cache
|
||||||
|
uses: actions/cache@v4
|
||||||
|
with:
|
||||||
|
path: ${{ env.STORE_PATH }}
|
||||||
|
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
|
||||||
|
restore-keys: |
|
||||||
|
${{ runner.os }}-pnpm-store-
|
||||||
|
|
||||||
|
- name: Install dependencies
|
||||||
|
run: pnpm install --frozen-lockfile
|
||||||
|
|
||||||
|
- name: Run tests
|
||||||
|
run: pnpm test
|
||||||
|
|
||||||
|
- name: Run build
|
||||||
|
run: pnpm build
|
||||||
|
|
||||||
|
- name: Validate version branch
|
||||||
|
run: |
|
||||||
|
echo "✅ Version branch validation passed"
|
||||||
|
if [[ "${{ github.event.pull_request.head.ref }}" =~ ^major/ ]]; then
|
||||||
|
echo "🚀 This will create a MAJOR release when merged"
|
||||||
|
elif [[ "${{ github.event.pull_request.head.ref }}" =~ ^minor/ ]]; then
|
||||||
|
echo "✨ This will create a MINOR release when merged"
|
||||||
|
else
|
||||||
|
echo "🐛 This will create a PATCH release when merged"
|
||||||
|
fi
|
||||||
|
|
||||||
version-and-publish:
|
version-and-publish:
|
||||||
if: github.event_name == 'push' || (github.event.pull_request.merged == true && (startsWith(github.event.pull_request.head.ref, 'major/') || startsWith(github.event.pull_request.head.ref, 'minor/') || startsWith(github.event.pull_request.head.ref, 'patch/')))
|
if: github.event_name == 'push'
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
outputs:
|
outputs:
|
||||||
new-version: ${{ steps.version-bump.outputs.new-version }}
|
new-version: ${{ steps.version-bump.outputs.new-version }}
|
||||||
@@ -333,7 +382,7 @@ jobs:
|
|||||||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
|
||||||
notify-success:
|
notify-success:
|
||||||
if: github.event_name == 'push' || (github.event.pull_request.merged == true && (startsWith(github.event.pull_request.head.ref, 'major/') || startsWith(github.event.pull_request.head.ref, 'minor/') || startsWith(github.event.pull_request.head.ref, 'patch/')))
|
if: github.event_name == 'push'
|
||||||
needs: version-and-publish
|
needs: version-and-publish
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
|
|||||||
Reference in New Issue
Block a user