xtr.dev/rondevu-client
1
0
Fork 0
mirror of https://github.com/xtr-dev/rondevu-client.git synced 2025-12-13 04:13:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace magic numbers with named constants in client

Browse Source 
Refactoring: Extract magic numbers to static constants
- DEFAULT_TTL_MS = 300000 (5 minutes)
- POLLING_INTERVAL_MS = 1000 (1 second)

Replaced in:
- ttl property initialization (line 173)
- publishService() default (line 335)
- startFilling() polling interval (line 500)
- connectToService() ICE polling (line 636)

Impact: Improves code clarity and maintainability
This commit is contained in:
Bas van den Aakster
2025-12-12 22:55:24 +01:00
parent c662161cd9
commit bd16798a2f
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/rondevu.ts
View File

@@ -153,6 +153,10 @@ interface ActiveOffer {
* ``` * ```
*/ */
export class Rondevu { export class Rondevu {
// Constants
private static readonly DEFAULT_TTL_MS = 300000 // 5 minutes
private static readonly POLLING_INTERVAL_MS = 1000 // 1 second
private api: RondevuAPI private api: RondevuAPI
private readonly apiUrl: string private readonly apiUrl: string
private username: string private username: string
@@ -166,7 +170,7 @@ export class Rondevu {
private currentService: string | null = null private currentService: string | null = null
private maxOffers = 0 private maxOffers = 0
private offerFactory: OfferFactory | null = null private offerFactory: OfferFactory | null = null
private ttl = 300000 // 5 minutes default private ttl = Rondevu.DEFAULT_TTL_MS
private activeOffers = new Map<string, ActiveOffer>() private activeOffers = new Map<string, ActiveOffer>()
// Polling // Polling
@@ -328,7 +332,7 @@ export class Rondevu {
this.currentService = service this.currentService = service
this.maxOffers = maxOffers this.maxOffers = maxOffers
this.offerFactory = offerFactory || this.defaultOfferFactory.bind(this) this.offerFactory = offerFactory || this.defaultOfferFactory.bind(this)
this.ttl = ttl || 300000 this.ttl = ttl || Rondevu.DEFAULT_TTL_MS
console.log(`[Rondevu] Publishing service: ${service} with maxOffers: ${maxOffers}`) console.log(`[Rondevu] Publishing service: ${service} with maxOffers: ${maxOffers}`)
this.usernameClaimed = true this.usernameClaimed = true
@@ -493,7 +497,7 @@ export class Rondevu {
// Start polling // Start polling
this.pollingInterval = setInterval(() => { this.pollingInterval = setInterval(() => {
this.pollInternal() this.pollInternal()
}, 1000) }, Rondevu.POLLING_INTERVAL_MS)
} }
/** /**
@@ -629,7 +633,7 @@ export class Rondevu {
} catch (err) { } catch (err) {
console.error('[Rondevu] Failed to poll ICE candidates:', err) console.error('[Rondevu] Failed to poll ICE candidates:', err)
} }
}, 1000) }, Rondevu.POLLING_INTERVAL_MS)
// 6. Set remote description // 6. Set remote description
await pc.setRemoteDescription({ await pc.setRemoteDescription({