xtr.dev/rondevu-client
1
0
Fork 0
mirror of https://github.com/xtr-dev/rondevu-client.git synced 2025-12-14 12:53:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix ICE candidate handling for Node.js compatibility

Browse Source 
Handle both browser and Node.js (wrtc) environments when processing ICE candidates. Browsers provide toJSON() method on candidates, but wrtc library candidates are already plain objects. Check for toJSON() existence before calling it.

Fixes: TypeError: event.candidate.toJSON is not a function in Node.js
This commit is contained in:
Bas van den Aakster
2025-12-13 15:19:45 +01:00
parent 0aa9921941
commit eb280e3826
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/rondevu.ts
View File

@@ -365,10 +365,17 @@ export class Rondevu {
pc.onicecandidate = async (event) => { pc.onicecandidate = async (event) => {
if (event.candidate) { if (event.candidate) {
try { try {
// Handle both browser and Node.js (wrtc) environments
// Browser: candidate.toJSON() exists
// Node.js wrtc: candidate is already a plain object
const candidateData = typeof event.candidate.toJSON === 'function'
? event.candidate.toJSON()
: event.candidate
await this.api.addOfferIceCandidates( await this.api.addOfferIceCandidates(
serviceFqn, serviceFqn,
offerId, offerId,
[event.candidate.toJSON()] [candidateData]
) )
} catch (err) { } catch (err) {
console.error('[Rondevu] Failed to send ICE candidate:', err) console.error('[Rondevu] Failed to send ICE candidate:', err)