xtr.dev/rondevu-demo
1
0
Fork 0
mirror of https://github.com/xtr-dev/rondevu-demo.git synced 2025-12-15 20:43:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix ICE candidate timing issue: Buffer candidates before offerId is available

Browse Source 
CRITICAL FIX: ICE gathering starts immediately when setLocalDescription() is
called, but we didn't have offerIds yet to send them to the server. This meant
all ICE candidates were lost before we could send them.

Solution:
- Attach temporary ICE handler BEFORE setLocalDescription()
- Buffer all ICE candidates in array until we have offerId
- After publishing and receiving offerIds, send all buffered candidates
- Replace handler with permanent one for any future candidates

This fixes the root cause of answerers not receiving any offerer candidates.
This commit is contained in:
Bas van den Aakster
2025-12-10 20:17:02 +01:00
parent 91b845aa1c
commit 249d1366d3
1 changed files with 31 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/App.jsx
View File

@@ -395,12 +395,23 @@ export default function App() {
// Setup handlers (will be enhanced with offerId later)
setupHostConnection(pc, dc, myUsername);
// Buffer ICE candidates until we have offerId
const candidateBuffer = [];
pc.onicecandidate = (event) => {
if (event.candidate) {
console.log(`[Host] Buffering ICE candidate for connection ${i}:`, event.candidate);
candidateBuffer.push(event.candidate.toJSON());
} else {
console.log(`[Host] ICE gathering complete for connection ${i} (buffered ${candidateBuffer.length} candidates)`);
}
};
// Create offer
const offer = await pc.createOffer();
await pc.setLocalDescription(offer);
offers.push({ sdp: offer.sdp });
connections.push({ pc, dc, index: i });
connections.push({ pc, dc, index: i, candidateBuffer });
}
// Publish service
@@ -422,14 +433,31 @@ export default function App() {
offerMapping[offer.offerId] = conn.pc;
hostConnMap[`host-${idx}`] = { pc: conn.pc, dc: conn.dc, offerId: offer.offerId, status: 'waiting' };
// Setup ICE candidate handler for offerer
// Send buffered ICE candidates
if (conn.candidateBuffer && conn.candidateBuffer.length > 0) {
console.log(`[Host] Sending ${conn.candidateBuffer.length} buffered ICE candidates for offer ${offer.offerId}`);
rondevu.addOfferIceCandidates(
fqn,
offer.offerId,
conn.candidateBuffer
).then(() => {
console.log(`✅ [Host] Successfully sent ${conn.candidateBuffer.length} buffered ICE candidates for offer ${offer.offerId}`);
}).catch(err => console.error(`[Host] Failed to send buffered ICE candidates for offer ${offer.offerId}:`, err));
}
// Setup ICE candidate handler for any future candidates
conn.pc.onicecandidate = (event) => {
if (event.candidate) {
console.log(`[Host] Sending new ICE candidate for offer ${offer.offerId}:`, event.candidate);
rondevu.addOfferIceCandidates(
fqn,
offer.offerId,
[event.candidate.toJSON()]
).catch(err => console.error(`[Host] Failed to send ICE candidate for offer ${offer.offerId}:`, err));
).then(() => {
console.log(`✅ [Host] Successfully sent ICE candidate for offer ${offer.offerId}`);
}).catch(err => console.error(`[Host] Failed to send ICE candidate for offer ${offer.offerId}:`, err));
} else {
console.log(`[Host] ICE gathering complete for offer ${offer.offerId} (null candidate)`);
}
};
});